debuginfo: LLDB crashes since liballoc is part of the distribution #14356
Comments
|
Yuck. The proposed workaround sounds fine.
|
|
Wow. I am in awe of this. |
LLDB contains a bug that makes it crash if an archive it reads contains a file the name of which is exactly 16 bytes long. This bug recently has made it impossible to debug Rust applications with LLDB because some standard libraries triggered it indirectly: For rlibs, rustc includes the LLVM bytecode in the archive, giving it the extension ".bc.deflate". For liballoc (for example) this results in the 16 character filename "alloc.bc.deflate", which is bad. This commit replaces the ".bc.deflate" suffix with ".bytecode.deflate" which itself is already longer than 16 bytes, thus making sure that the bug won't be run into anymore. The bug could still be run into with 14 character filenames because then the .o files will trigger it. However, this is much more rare and working around it would introduce more complexity than necessary at the moment. It can always be done later on, if the need arises. Fixes rust-lang#14356.
LLDB contains a bug that makes it crash if an archive it reads contains a file the name of which is exactly 16 bytes long. This bug recently has made it impossible to debug Rust applications with LLDB because some standard libraries triggered it indirectly: For rlibs, rustc includes the LLVM bytecode in the archive, giving it the extension ".bc.deflate". For liballoc (for example) this results in the 16 character filename "alloc.bc.deflate", which is bad. This commit replaces the ".bc.deflate" suffix with ".bytecode.deflate" which itself is already longer than 16 bytes, thus making sure that the bug won't be run into anymore. The bug could still be run into with 14 character filenames because then the .o files will trigger it. However, this is much more rare and working around it would introduce more complexity than necessary at the moment. It can always be done later on, if the need arises. Fixes rust-lang#14356.
LLDB contains a bug that makes it crash if an archive it reads contains a file the name of which is exactly 16 bytes long. This bug recently has made it impossible to debug Rust applications with LLDB because some standard libraries triggered it indirectly: For rlibs, rustc includes the LLVM bytecode in the archive, giving it the extension ".bc.deflate". For liballoc (for example) this results in the 16 character filename "alloc.bc.deflate", which is bad. This commit replaces the ".bc.deflate" suffix with ".bytecode.deflate" which itself is already longer than 16 bytes, thus making sure that the bug won't be run into anymore. The bug could still be run into with 14 character filenames because then the .o files will trigger it. However, this is much more rare and working around it would introduce more complexity than necessary at the moment. It can always be done later on, if the need arises. Fixes rust-lang#14356.
It seems that there's a bug in LLDB that causes it to crash when the name of an object file is exactly 16 characters long. Unfortunately we are now running into this bug because of the file "alloc.bc.deflate" created during the build process. I have filed a bug report about this [1], but in the meantime this bug is present in every LLDB version ever [2], so I guess we need to do something about it on our end.
My proposal would be to check if we generate a filename which triggers the bug and if yes, then just add an additional character to it (e.g. "alloc.bc.deflate" -> "alloc.bc.deflate0").
If somebody has a better idea, please let me know. Otherwise I'll implement this next week.
[1] http://llvm.org/bugs/show_bug.cgi?id=19826
[2] Commit message by Chris Lattner: "Initial checkin of lldb code from internal Apple repo."
:)cc @alexcrichton @brson
The text was updated successfully, but these errors were encountered: