Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passes to mark stability and must-use attributes as used #14407

Closed
sfackler opened this issue May 24, 2014 · 4 comments
Closed

Add passes to mark stability and must-use attributes as used #14407

sfackler opened this issue May 24, 2014 · 4 comments
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

The unused-attribute lint globally whitelists stability and must-use attributes as they're only looked for on-demand. There should be another pass added to mark them used only in the correct contexts.
@huonw huonw mentioned this issue Aug 4, 2014
Closed
@sfackler sfackler mentioned this issue Dec 15, 2014
Merged
@steveklabnik
Copy link
Member

Triage: no change that I'm aware of.

@steveklabnik
Copy link
Member

Triage: still no change that I'm aware of.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 25, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum changed the title Add passes to mark stability and must-use attributes Add passes to mark stability and must-use attributes as used Jul 21, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 21, 2017
@zackmdavis zackmdavis mentioned this issue Oct 27, 2017
Closed
@zackmdavis zackmdavis mentioned this issue Jan 25, 2018
Closed
@steveklabnik
Copy link
Member

Triage: no changes I'm aware of.

@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 12, 2020
@jonas-schievink jonas-schievink added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Apr 1, 2020
@ehuss
Copy link
Contributor

ehuss commented Nov 12, 2021

Closing as the unused attribute handling has been rewritten in #87739 and should now handle stability and must_use attributes.

@ehuss ehuss closed this as completed Nov 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14407 - Veykril:rename-fix, r=Veykril
d1c7984 
fix: Fix renames of locals being broken in macro calls

Fixes rust-lang/rust-analyzer#14379
@fmease fmease added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. and removed A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. labels Dec 21, 2024
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 3, 2025
@Jarcho
Allow #[expect] and #[allow] within function bodies for `missing_…
b96fecf 
…panics_doc` (rust-lang#14407)

Implements
rust-lang/rust-clippy#11436 (comment)

> [...] I'd really like to be able to (reusing some above examples),
>
> ``` rust
> /// Do something
> pub fn string_from_byte_stream() -> String {
>     let bytes = get_valid_utf8();
> #[expect(clippy::missing_panics_doc_ok, reason="caller can't do
anything about this")]
> String::from_utf8(bytes).expect("`get_valid_utf8()` always returns
valid UTF-8")
> }
> ```

Also fixes an issue where if the first panic is in a `const` context
disables the lint for the rest of the function

The first commit is just moving code around

changelog: [`missing_panics_doc`]: `#[allow]` and `#[expect]` can now be
used within the function body to ignore individual panics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@steveklabnik @ehuss @sfackler @jonas-schievink @Mark-Simulacrum @fmease