-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Description
Running ./x test --stage 1 tests/run-make/linker-warning
locally with an unmodified stage1 build of rustc
leads to a test failure because an actual linker error doesn't match the expected one.
Here's the diff output by compiletest:
--- short-error.txt
+++ (linker error)
@@ -1,6 +1,6 @@
error: linking with `./fake-linker` failed: exit status: 1
|
- = note: "./fake-linker" "-m64" "/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/build-root/test/run-make/linker-warning/rmake_out/{libfoo,libbar}.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/build-root/test/run-make/linker-warning/rmake_out" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "run_make_error"
+ = note: "./fake-linker" "-m64" "/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "/home/fmease/programming/rust/rustc/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out/{libfoo,libbar}.rlib" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/home/fmease/programming/rust/rustc/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "run_make_error"
= note: some arguments are omitted. use `--verbose` to show all linker arguments
= note: error: baz
Note that the following normalization step didn't kick in in two places:
.normalize(
regex::escape(
run_make_support::build_root().canonicalize().unwrap().to_str().unwrap(),
),
"/build-root",
)
That's because allegedly the actual paths passed to the (fake) linker are /home/fmease/programming/rust/rustc/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out/{libfoo,libbar}.rlib
and /home/fmease/programming/rust/rustc/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out
while they are were expected to be /home/fmease/programming/rust/rustc3/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out/{libfoo,libbar}.rlib
and /home/fmease/programming/rust/rustc3/build/x86_64-unknown-linux-gnu/test/run-make/linker-warning/rmake_out
, respectively.
To make this clearer, allegedly my stage1 rustc passes the path prefix /home/fmease/programming/rust/rustc/
(which is a path that doesn't exist on my machine!) to the linker but the run-make test expects /home/fmease/programming/rust/rustc3/
(which is a path that exists on my machine, it's my CWD / the place I've executed ./x test
in (it's one of my four local r-l/r.git checkouts)).
That stage1 build is of commit a015919 from Sep 13 2025 (base: 1.91.0). Host: x86_64-unknown-linux-gnu.