Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument names missing for default methods of cross-crate implementations of traits #14716

Closed
sfackler opened this issue Jun 7, 2014 · 2 comments
Closed

Argument names missing for default methods of cross-crate implementations of traits #14716

sfackler opened this issue Jun 7, 2014 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

sfackler commented Jun 7, 2014

I thought there was a bug for this, but I couldn't seem to find it.

e.g. http://doc.rust-lang.org/collections/bitv/struct.Bitv.html#tymethod.clone_from
@alexcrichton
Copy link
Member

This may have been fixed by #14675. I'll check tomorrow once the docs are uploaded.

@sfackler
Copy link
Member Author

sfackler commented Jun 7, 2014

Yep, looks like it's fixed.

@sfackler sfackler closed this as completed Jun 7, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14716 - Veykril:trait-deps-query, r=Veykril
cffc402 
Don't merge trait_impls_in_deps results

Closes rust-lang/rust-analyzer#9167

We effectively keep a lot of copies of `TraitImpl` results in memory by merging them into the result of this query. This wastes a lot of memory unnecessarily. The change here brings memory usage of self down by 50mb (at a slight cost of trait solving unfortunately, though I'm hopeful it was just noice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @sfackler