Skip to content

compiletest: error on duplicate directives #148359

@jieyouxu

Description

@jieyouxu

E.g.

//@ add-minicore
//@ compile-flags: --target thumbv8m.main-none-eabi --crate-type lib
//@ needs-llvm-components: arm
//@ add-minicore

should produce an error.

However, note that this should only apply for non-additive directives, e.g.

//@ compile-flags: -Cabc
//@ compile-flags: -Cdef

are additive directives, so that must not error.

(Blocked on reworking how directives are registered/handled in the first place to avoid making more complications.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions