Skip to content

Need custom discriminant tests in the pretty printer #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Jan 13, 2012 · 0 comments
Closed

Need custom discriminant tests in the pretty printer #1510

nikomatsakis opened this issue Jan 13, 2012 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@nikomatsakis
Copy link
Contributor

Right now, they don't get pretty printed at all!

What needs to be done:

  • First, add a test or two to test/pretty with the pp-exact directive, as described in the wiki.
  • Second, modify the pretty printer in comp/syntax/print/pprust.rs to emit the custom discriminants if present.
@kevina kevina mentioned this issue Jan 16, 2012
Closed
kevina added a commit to kevina/rust that referenced this issue Jan 16, 2012
@kevina
Update pretty printer to print out disr. values.
50d991d 
Partly fixes issue rust-lang#1510.  "rustc --pretty=typed" fails.
marijnh pushed a commit that referenced this issue Jan 16, 2012
@kevina @marijnh
Update pretty printer to print out disr. values.
2d36a71 
Partly fixes issue #1510.  "rustc --pretty=typed" fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More cleanups to commits for issue #1393 kevina/rust
2 participants
@marijnh @nikomatsakis