Skip to content

Cleanup bootstrap rust-docs dist component handling #151292

@jieyouxu

Description

@jieyouxu

This is a long-standing cleanup that needs to be done eventually:

  • Get rid of doc_out -- using the same shared directory for multiple doc steps is wrong, there should be an explicit "build separately but eventually merge together" step to prevent any possibility of doc step artifacts stepping over each other.
  • Do not rely on run_default_doc_steps which is way too implicit; instead, explicitly enumerate the "default steps" that should be included as part of the "preset" Doc step.

For the "implicit" part, note that we use this logic for both rust-docs dist component and rustc-docs dist component.

For the "explict" part, we also ensure them in:

  • test::Linkcheck
  • test::HtmlCheck

(Needs further investigation, there are some convoluted recursive logic)

Metadata

Metadata

Assignees

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.E-needs-investigationCall for participation: This issues needs some investigation to determine current statusT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions