Skip to content

Consider using Result for FromStr, FromStrRadix and friends #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 23, 2014 · 1 comment · Fixed by #21718
Closed

Consider using Result for FromStr, FromStrRadix and friends #15138

brson opened this issue Jun 23, 2014 · 1 comment · Fixed by #21718

Comments

@brson
Copy link
Contributor

brson commented Jun 23, 2014

During https://github.com/rust-lang/rust/wiki/Meeting-API-review-2014-06-23#uint, these functions failed review because some people felt that they should be returning Result instead of Option.
@brson brson added the A-libs label Jun 23, 2014
@aturon
Copy link
Member

aturon commented Jun 23, 2014

cc me

@Ryman Ryman mentioned this issue Jun 27, 2014
Closed
bors added a commit that referenced this issue Jul 5, 2014
@bors
auto merge of #15225 : Ryman/rust/liburl_minor, r=alexcrichton
b8ef5cf 
See commits for info, a number of these are 'breaking', although liburl is marked experimental so I'm not sure that matters so much.

First two commits will be impacted if #15138 is adopted, but it's a simple rename.
@alexcrichton alexcrichton mentioned this issue Jan 28, 2015
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 30, 2015
@alexcrichton
std: Stabilize FromStr and parse
0cdde6e 
This commits adds an associated type to the `FromStr` trait representing an
error payload for parses which do not succeed. The previous return value,
`Option<Self>` did not allow for this form of payload. After the associated type
was added, the following attributes were applied:

* `FromStr` is now stable
* `FromStr::Err` is now stable
* `FromStr::from_str` is now stable
* `StrExt::parse` is now stable
* `FromStr for bool` is now stable
* `FromStr for $float` is now stable
* `FromStr for $integral` is now stable
* Errors returned from stable `FromStr` implementations are stable
* Errors implement `Display` and `Error` (both impl blocks being `#[stable]`)

Closes rust-lang#15138
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 30, 2015
@alexcrichton
rollup merge of rust-lang#21718: alexcrichton/stabilize-from-str
ac1a03d 
This commits adds an associated type to the `FromStr` trait representing an
error payload for parses which do not succeed. The previous return value,
`Option<Self>` did not allow for this form of payload. After the associated type
was added, the following attributes were applied:

* `FromStr` is now stable
* `FromStr::Err` is now stable
* `FromStr::from_str` is now stable
* `StrExt::parse` is now stable
* `FromStr for bool` is now stable
* `FromStr for $float` is now stable
* `FromStr for $integral` is now stable
* Errors returned from stable `FromStr` implementations are stable
* Errors implement `Display` and `Error` (both impl blocks being `#[stable]`)

Closes rust-lang#15138
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@alexcrichton @Manishearth
std: Stabilize FromStr and parse
ccdfb09 
This commits adds an associated type to the `FromStr` trait representing an
error payload for parses which do not succeed. The previous return value,
`Option<Self>` did not allow for this form of payload. After the associated type
was added, the following attributes were applied:

* `FromStr` is now stable
* `FromStr::Err` is now stable
* `FromStr::from_str` is now stable
* `StrExt::parse` is now stable
* `FromStr for bool` is now stable
* `FromStr for $float` is now stable
* `FromStr for $integral` is now stable
* Errors returned from stable `FromStr` implementations are stable
* Errors implement `Display` and `Error` (both impl blocks being `#[stable]`)

Closes rust-lang#15138
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 17, 2023
@bors
Auto merge of rust-lang#15138 - mohsen-alizadeh:13583-rename-runnable…
d7f4c21 
…Env-to-runnables-extraEnv, r=Veykril

13583 rename runnable env to runnables extra env

closes rust-lang#13583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Stabilize FromStr and parse alexcrichton/rust
2 participants
@brson @aturon