Skip to content

clearly define the intended purpose of feature gates in the documentation #15176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thestinger opened this issue Jun 25, 2014 · 4 comments
Closed

Comments

@thestinger
Copy link
Contributor

Do experimental features need to be accepted as an RFC to be added behind a feature gate? For example, #![feature(struct_inherit)] was added after the RFC process was put in place.

At the moment, some RFCs are closed and classified as postponed rather than being rejected. It isn't clear whether this means initial experimental work can happen behind a feature gate, especially in cases where it isn't a large / invasive feature.

@thestinger thestinger changed the title clearly define the intended purpose of feature gates clearly define the intended purpose of feature gates in the documentation Jun 25, 2014
@nrc
Copy link
Member

nrc commented Jun 25, 2014

Yes. Features that were accepted by the old 'process' of meeting discussions are considered to be grandfathered in (there is no RFC for DST for example).

(For the record, the first PR for struct_inherit landed on the 26th Feb and the RFC process began around the 12th March (date of first PR). If struct_inherit were proposed now, it would need an RFC and indeed there are several proposed RFCs for development of the idea and no work has been or will be done until that's gone through the RFC process).

@lucy
Copy link
Contributor

lucy commented Jun 25, 2014

Perhaps it should be possible to have RFCs accepted for implementation behind a feature gate (if anyone is interested) despite not being in scope for 1.0?

@sanxiyn
Copy link
Member

sanxiyn commented Jun 25, 2014

RFC PR 15(SIMD) is entirely behind a feature gate but rejected. I infer that even the experimental work behind a feature gate needs to go through RFC if it is "substantial", in the language of RFC 1. I don't exactly agree with that, but that seems to be the status quo.

@steveklabnik
Copy link
Member

This story is clear now, as all new features will land behind a gate until they are deemed stable.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 17, 2023
Purge of unwraps

Removes unnecessary unwraps that I have overlooked in rust-lang#15101 ( fixes rust-lang#15176 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants