-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Closed
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
#151036 improved trait-not-implemented diagnostics in some cases, by explicitly mentioning that the trait in question is unstable:
| "nightly-only, unstable " |
An unfortunate side-effect of that change is that when a trait-not-implemented error occurs while working on the compiler itself, for a trait defined in the compiler source (whether pub or not), that extra text always appears.
This is technically “correct” because rustc crates are built with -Zforce-unstable-if-unmarked. But it's unhelpful and confusing for compiler contributors.
We can probably carve out some kind of narrow exemption to suppress the extra text, perhaps even just automatically hiding it when -Zforce-unstable-if-unmarked is set (or another -Z flag that correlates with working on the compiler).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.