-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Std docs links are not all highlighted #15307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Primitive type f32 has the same issue: [EDIT] Removed sidebar circles. Never thought they needed changing. |
Totally agree. Also, instead of colors, we could use dashed underlines to indicate links while still keeping the same feel. (I disagree about the sidebar as well, I think its normal to expect those to be links, because they're in a sidebar without any text) |
Sidebar is fine, thats a pretty normal convention to have those as links. At first glance I didn't realize most of the text in the main doc area was clickable however, I really like the idea of having the dashed underlines. +1 |
Didn't think sidebar necessarily should change. Was just highlighting black links. Edited pictures to removed sidebar circles. |
code is
and maybe some sort of style so it doesn't show up on the [src] link |
CC: @steveklabnik |
I like that style, I think. I am bad at looks, though. |
@nightpool If there are any other decent styles worth pursuing (different brown variant, solid underline, combo, red...I'm just guess here), a quick mockup of them would allow easy compare and contrast. It would allow an easier/faster decision. |
+1 from me |
I'm currently playing with rustdoc. I may try to implement this once the docs are built. |
This is an alternative to rust-lang#29240 which fixes rust-lang#15307 by adding colors to primitives and aliases instead of underlining. Try to keep the discussion in rust-lang#29240 for now though so it can be kept track of. A sample rendering is [here](http://mdinger.github.io/rust_std_colored/std/index.html)
Std doc links should have colors to highlight that they are links:
Some users find it difficult to know which items are links.
[EDIT] Removed sidebar circles. Never thought they needed changing.
The text was updated successfully, but these errors were encountered: