-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy between compilation of crates and single-file executables. #15348
Comments
The phenomena you're seeing here is that |
I sort of think we should always put |
@ben0x539 your suggestion sounds very much to me like rust-lang/rfcs#110 ; can you elaborate on where it differs? Or are they indeed the same idea? |
@pnkfelix I think I descibred that really badly. I'm basically suggesting that given That wouldn't address the problem that rust-lang/rfcs#110 tries to solve at all, you'd still need a mechanism to ensure that the same crate is referenced by the same path in completely different compilation units. |
This is the kind of item which would require an RFC to change, I'd think. Feel free to persue this over there! |
Exclude non-identifier aliases from completion filtering text When building `CompletionItem`s, this excludes aliases that aren't valid identifiers from the "lookup" text used to filter completions in the LSP client. Including them results in weird completion filtering behavior e.g. `Partial>` matching a completion for the `PartialOrd` trait because it has a doc alias of ">". Closes rust-lang#14692
I have two files:
module.rs
lib.rs
rustc module.rs
compiles without any problems.rustc lib.rs
yields the error message:The text was updated successfully, but these errors were encountered: