Skip to content

Do something better when there's a mismatch between identical-looking regions #15391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jul 4, 2014 · 5 comments
Closed
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lifetimes Area: Lifetimes / regions A-type-system Area: Type system

Comments

@brson
Copy link
Contributor

brson commented Jul 4, 2014

It's a very common experience for rustc to tell you it couldn't unify two regions, then print out the span of those regions, only to have them look identical. Seeing enough of these can be rage-inducing.

I don't have a great concrete suggestion, but even just printing a single region and saying something like 'yeah, I know these regions look the same. sorry', might ease the pain a bit.

@pnkfelix
Copy link
Member

pnkfelix commented Jul 4, 2014

cc me

@steveklabnik
Copy link
Member

Triage: unsure if this is still a problem, exactly. @brson how do you feel about this now?

@pnkfelix
Copy link
Member

I think we still encounter this (though maybe the finer grain scopes added due to dropck have made slightly different scopes, and thus shifted the rage slightly).

@brson's suggestion of at least acknowledging when the spans are identical might still be a good idea for the short term.

@brson
Copy link
Contributor Author

brson commented May 1, 2015

I haven't seen this recently, but I haven't written a lot of Rust recently.

@steveklabnik
Copy link
Member

I'm going to close this issue for being a bit too vague. If you see something like it with some concrete code, please open a new issue so we can tackle those specific issues.

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 7, 2023
Set the default status bar action to openLogs

Previously, clicking 'rust-analyzer' would stop the server entirely. This was easy to do accidentally, and then the user has to wait for the server to start up again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lifetimes Area: Lifetimes / regions A-type-system Area: Type system
Projects
None yet
Development

No branches or pull requests

4 participants