Skip to content

make install (to non-standard prefix) is failing #15545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chris-morgan opened this issue Jul 9, 2014 · 4 comments · Fixed by #15550
Closed

make install (to non-standard prefix) is failing #15545

chris-morgan opened this issue Jul 9, 2014 · 4 comments · Fixed by #15550

Comments

@chris-morgan
Copy link
Member 

$ make install
…
install: validating tmp/dist/rust-0.11.0-x86_64-unknown-linux-gnu/install.sh args
install: 
install: verifying platform can run binaries
/home/chris/rust/tmp/dist/rust-0.11.0-x86_64-unknown-linux-gnu/bin/rustc: error while loading shared libraries: librustc-4e7c5e5c.so: cannot open shared object file: No such file or directory
install: error: can't execute rustc binary on this platform
/home/chris/rust/mk/install.mk:18: recipe for target 'install' failed
make: *** [install] Error 1

At this point, /home/chris/rust/tmp/dist/rust-0.11.0-x86_64-unknown-linux-gnu/lib/librustc-4e7c5e5c.so and /home/chris/rust/tmp/dist/rust-0.11.0-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc-4e7c5e5c.so both exist.

Just in case it matters: my prefix is /home/chris/opt/rust.
@chris-morgan
Copy link
Member Author

Fallout from #14832, perhaps?

This isn’t the first time we’ve had make install completely broken (two months ago it happened, #14033). Why don’t we add it to the tests done on the buildbot?

@pnkfelix pnkfelix changed the title make install is failing make install (to non-standard prefix) is failing Jul 9, 2014
@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2014

Indeed, this was predicted as a known consequence of #14832.

It may be the case that asking people to set LD_LIBRARY_PATH is too much. We might need/want wrapper scripts to drive rustc that set up such environment variables, much like other projects have.

@alexcrichton alexcrichton mentioned this issue Jul 9, 2014
Merged
@alexcrichton
Copy link
Member

Fixed by #15550.

@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2014

(see comment #15550 (comment) , since it is relevant to this issue.)

bors added a commit that referenced this issue Jul 9, 2014
@bors
auto merge of #15550 : alexcrichton/rust/install-script, r=brson
942c72e 
This adds detection of the relevant LD_LIBRARY_PATH-like environment variable
and appropriately sets it when testing whether binaries can run or not.
Additionally, the installation prints a recommended value if one is necessary.

Closes #15545
@chris-morgan chris-morgan mentioned this issue Jan 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

etc: Fix install script for rpath removal alexcrichton/rust
4 participants
@alexcrichton @pnkfelix @chris-morgan @huonw