Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antlr is losing information #15677

Closed
emberian opened this issue Jul 14, 2014 · 6 comments
Closed

antlr is losing information #15677

emberian opened this issue Jul 14, 2014 · 6 comments
Labels
A-grammar Area: The grammar of Rust A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@emberian
Copy link
Member

See http://stackoverflow.com/questions/24747360/distinguishing-literal-n-vs-embedded-newline. Until there is a resolution to this, the lexer verification is ignoring the contents every token that carries data :(

@steveklabnik
Copy link
Member

traige: no changes that i'm aware of

@nagisa
Copy link
Member

nagisa commented Mar 17, 2016

While we still have ANTLR grammar in tree, it is outdated and we predominantly rely on the other one we have in tree. Perhaps we should just remove ANTLR one now?

@emberian
Copy link
Member Author

The ANTLR grammar was originally intended to be "pure" in the sense that it uses only language description and no code in its operation, and could easily be lifted into some formalism. This is quite at odds with how the flex and bison files operate.

@steveklabnik
Copy link
Member

I would be okay removing ANTLR.

On Mar 17, 2016, 05:47 -0400, cmrnotifications@github.com, wrote:

The ANTLR grammar was originally intended to be "pure" in the sense that it uses only language description and no code in its operation, and could easily be lifted into some formalism. This is quite at odds with how the flex and bison files operate.


You are receiving this because you commented.
Reply to this email directly orview it on GitHub(#15677 (comment))

@Mark-Simulacrum
Copy link
Member

ANTLR grammar is still in-tree. There is now an answer to the SO question, though, so perhaps that's significant to this discussion? It's possible the easiest answer here is to simply remove the ANTLR grammar from in-tree, possibly moving it elsewhere.

@steveklabnik
Copy link
Member

Agreed; I'd be happy to just remove it. We're not planning on doing anything with ANTLR in the future that I know of, and if we need it, we can pull it back out of the history.

frewsxcv added a commit to frewsxcv/rust that referenced this issue May 3, 2017
…ikomatsakis

Remove ANTLR grammar

I *think* that nothing in-tree references this, but I may be wrong. If anyone thinks of anything, please let me know and I'll work on removing.

Fixes rust-lang#15677.
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 13, 2023
Allocate ast ids for parameters

Since these can have attributes attached to them, we'll need this sooner or later (sooner being me tinkering with the token map right now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-grammar Area: The grammar of Rust A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

4 participants