Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model lexer doesn't handle question marks #15879

Closed
emberian opened this issue Jul 21, 2014 · 0 comments
Closed

Model lexer doesn't handle question marks #15879

emberian opened this issue Jul 21, 2014 · 0 comments

Comments

@emberian
Copy link
Member

Tracking issue for the lexer test failing test/run-pass/unsized.rs
@emberian emberian mentioned this issue Jul 21, 2014
Closed
7 tasks
@fhahn fhahn mentioned this issue Jan 13, 2015
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 15, 2015
@alexcrichton
rollup merge of rust-lang#21120: fhahn/issue-model-lexer-questionmark
b83fee0 
This PR updates `grammar/verify.rs` to work with master and handles the question mark of `?Sized` correctly (rust-lang#15879).
@bors bors closed this as completed in d397a3e Jan 16, 2015
richo added a commit to richo/rust that referenced this issue Mar 9, 2015
@richo
test: Test the lexer now that rust-lang#15879 is closed
5b7bfc8
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 4, 2023
@bors
Auto merge of rust-lang#15879 - dfireBird:fix-14656, r=Veykril
e402c49 
Implement completion for the callable fields.

Fixes rust-lang#14656

PR is opened with basic changes. It could be improved by having a new `SymbolKind` for the callable fields and implementing a separate render function similar to the `render_method` for the new `SymbolKind`.
It could also be done without any changes to the `SymbolKind` of course, have the new function called based on the type of field.
I prefer the former method.

Please give any thoughts or changes you think is appropriate for this method. I could start working on that in this same PR.
lnicola pushed a commit to lnicola/rust that referenced this issue Jan 3, 2024
@bors
Auto merge of rust-lang#16049 - dfireBird:followup-callable-fields, r…
60fe5fd 
…=Veykril

fix: make callable fields not complete in method access no parens case

Follow up PR for rust-lang#15879

Fixes the callable field completion appearing in the method access with no parens case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emberian