Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code browser horizontal scroll bar is hard to find #15891

Closed
mdinger opened this issue Jul 22, 2014 · 3 comments
Closed

Source code browser horizontal scroll bar is hard to find #15891

mdinger opened this issue Jul 22, 2014 · 3 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Jul 22, 2014

Go to std::iter docs and click src at the top right.

The src code is wider than the frame it sits in but the horizontal scroll bar is way way (1500 lines) down at the bottom of the page. Arrow keys work for scrolling but it may not be obvious though. It's also not obvious that you can scroll horizontally without checking all the way to the bottom.

It'd be nice to allow horizontal scrolling somehow without going to the bottom of the page or using the arrow keys.

@emberian
Copy link
Member

Certainly a problem. I have no idea how one would go about fixing this, though.

@Gankra
Copy link
Contributor

Gankra commented Jul 29, 2014

Deleting main.cs:145:

.content, nav { max-width: 960px; }

Fixes this. This might have consequences elsewhere, though. Regardless, this is the spirit of the solution: Code shouldn't scroll its container, it should overflow it, so that the page itself scrolls.

@mdinger
Copy link
Contributor Author

mdinger commented Jul 29, 2014

I don't know how to fix it either. Having the width increase with the windows size might also work. Or a horizontal scrollbar which floats at the visible bottom of the page (don't know if it's possible).

Gankra added a commit to Gankra/rust that referenced this issue Jul 29, 2014
* Make the code fill up the full width of the page (no massive whitespace on the left)
* Move the code down to make it not intersect the logo
* Set a min-width and remove the max-width so that the code doesn't scroll internally, but instead scrolls the page, meaning horizontal scroll bars are always available
* Set overflow to actually overflow, just to be sure

Fixes rust-lang#15891
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2023
feat: Diagnose some orphan trait impl cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants