Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: quote_expr! is broken now #15931

Closed
farcaller opened this issue Jul 23, 2014 · 4 comments
Closed

regression: quote_expr! is broken now #15931

farcaller opened this issue Jul 23, 2014 · 4 comments
Labels
A-syntaxext Area: Syntax extensions

Comments

@farcaller
Copy link
Contributor

This code is now unexpectedly broken:

  debug!("quote_expr clock_source={clock_source}, pll_m={pll_m}, pll_n={pll_n}, pll_divisor={pll_divisor}",
      clock_source=clock_source,
      pll_m=pll_m,
      pll_n=pll_n,
      pll_divisor=pll_divisor);
  let ex = quote_expr!(&*cx,
      {
        use zinc::hal::lpc17xx::system_clock;
        system_clock::init_clock(
            &system_clock::Clock {
              source: $clock_source,
              pll: core::option::Some(system_clock::PLL0 {
                m: $pll_m,
                n: $pll_n,
                divisor: $pll_divisor,
              })
            }
        );
      }
  );
  debug!("ok");
DEBUG:platformtree::lpc17xx_pt::system_clock_pt: quote_expr clock_source=TokenString(system_clock::Main(12000000)), pll_m=50, pll_n=3, pll_divisor=4
/Users/farcaller/src/zinc/apps/app_empty.rs:1:1: 1:1 error: unexpected token: `=`

I think I'm pretty sure it breaks here (as the "ok" line is never printed). The code works flawlessly if built standalone: http://is.gd/vRmStw.

I don't know where this = is coming from, any ideas?

@errordeveloper
Copy link
Contributor

@fracaller do you know which is the last nightly build that worked?

@farcaller
Copy link
Contributor Author

I think, that tuesday build was fine. I'm bisecting from previous friday though.

@errordeveloper
Copy link
Contributor

I see that a 4 days old f15d6d2 works here.

@farcaller
Copy link
Contributor Author

This seem to be related to a different issue, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions
Projects
None yet
Development

No branches or pull requests

3 participants