Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding type annotations in comments #16143

Closed
steveklabnik opened this issue Jul 31, 2014 · 1 comment · Fixed by #19743
Closed

Consider adding type annotations in comments #16143

steveklabnik opened this issue Jul 31, 2014 · 1 comment · Fixed by #19743

Comments

@steveklabnik
Copy link
Member

In #16119 (comment), @jvns mentions that extra type annotations helped her a lot when she was learning. Yet, I don't want to encourage bad Rust style from the start.

We should consider maybe adding annotations as comments to the guide.
@steveklabnik steveklabnik mentioned this issue Jul 31, 2014
Merged
@ghost
Copy link

ghost commented Aug 12, 2014

It should be possible to type annotate all code examples automatically and have types pop up when hovering over identifiers or similar.

@steveklabnik steveklabnik mentioned this issue Dec 11, 2014
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Dec 11, 2014
@steveklabnik
Add comments with type annotations.
31b240d 
This will hopefully help people with their first steps in Rust.

Fixes rust-lang#16143.
brson added a commit to brson/rust that referenced this issue Dec 16, 2014
@brson
rollup merge of rust-lang#19743: steveklabnik/gh16143
0aedfee 
This will hopefully help people with their first steps in Rust.

Fixes rust-lang#16143.

/cc @jvns
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 17, 2014
@alexcrichton
rollup merge of rust-lang#19743: steveklabnik/gh16143
bfb5f8b 
This will hopefully help people with their first steps in Rust.

Fixes rust-lang#16143.

/cc @jvns
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 3, 2024
@bors
Auto merge of rust-lang#16143 - Veykril:base-db-no-proc-macros, r=lni…
cfc959d 
…cola

internal: Move proc-macro knowledge out of base-db into hir-expand

It does not make much sense to me to have that live in base-db, additionally, it kind of conflicts with moving span things out into a separate crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comments with type annotations. steveklabnik/rust
1 participant
@steveklabnik