Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide: make less ignores #16219

Closed
steveklabnik opened this issue Aug 3, 2014 · 2 comments · Fixed by #19714
Closed

Guide: make less ignores #16219

steveklabnik opened this issue Aug 3, 2014 · 2 comments · Fixed by #19714
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@steveklabnik
Copy link
Member

as @huonw points out here: https://github.com/rust-lang/rust/pull/16206/files#r15733110

I didn't realize that I could do this for examples, and so many more of them can become non-ignore. After the full first draft is up, each ignored example should get a review to see if it can be made non-ignore.
@steveklabnik steveklabnik mentioned this issue Aug 3, 2014
Merged
@steveklabnik
Copy link
Member Author

Also should_fail is probably better than ignore on most of these. I suck at rustdoc.

@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-papercut and removed E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Dec 4, 2014
@steveklabnik
Copy link
Member Author

I haven't been able to get should_fail to work :/

@steveklabnik steveklabnik mentioned this issue Dec 10, 2014
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Dec 10, 2014
@steveklabnik
Fix up some {ignore} and {notrust}s
3c9d898 
These should be properly annotated instead.

Fixes rust-lang#16219.
brson added a commit to brson/rust that referenced this issue Dec 12, 2014
@brson
rollup merge of rust-lang#19714: steveklabnik/gh16219
0dda9e2 
These should be properly annotated instead.

Fixes rust-lang#16219.
brson added a commit to brson/rust that referenced this issue Dec 15, 2014
@brson
rollup merge of rust-lang#19714: steveklabnik/gh16219

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
42f4d63 
These should be properly annotated instead.

Fixes rust-lang#16219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix up some {ignore} and {notrust}s steveklabnik/rust
1 participant
@steveklabnik