Skip to content

Building the compiler on 64-bit Windows fails in rust_builtin.c / valgrind.h (uintptr_t not defined) #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesluke opened this issue Aug 8, 2014 · 1 comment

Comments

@jamesluke
Copy link
Contributor

As the title says. src/rt/rust_builtin.c includes src/rt/valgrind/valgrind.h, valgrind.h uses the uintptr_t type defined in <stdint.h> but does not include <stdint.h> itself.

Either rust_builtin.c needs to include <stdint.h> before valgrind.h, or valgrind.h needs to include <stdint.h> along with an include guard. I'd do this myself, but I should presumably understand the code at least slightly before I mess about with it.

@huonw
Copy link
Member

huonw commented Aug 8, 2014

Fixed by #16323.

@bors bors closed this as completed in a23d679 Aug 9, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 15, 2024
internal: Consider all kinds of explicit private imports in find_path

Builds on top of rust-lang/rust-analyzer#16265 to make things a bit more general, now we consider all explicit private imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants