Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use id = path; with use path as id; #16461

Closed
nikomatsakis opened this issue Aug 12, 2014 · 5 comments · Fixed by #16575 or #17048
Closed

Replace use id = path; with use path as id; #16461

nikomatsakis opened this issue Aug 12, 2014 · 5 comments · Fixed by #16575 or #17048
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@nikomatsakis
Copy link
Contributor

Tracking issue for RFC 47
@nikomatsakis
Copy link
Contributor Author

cc @pnkfelix

@pnkfelix
Copy link
Member

Nominating, suggest tagging a P-backcompat-lang, 1.0

@pcwalton pcwalton mentioned this issue Aug 13, 2014
Merged
pcwalton added a commit to pcwalton/rust that referenced this issue Aug 14, 2014
@pcwalton
libsyntax: Accept use foo as bar; in lieu of use bar as foo;
1c16acc 
The old syntax will be removed after a snapshot.

RFC rust-lang#47.

Issue rust-lang#16461.
bors added a commit that referenced this issue Aug 14, 2014
@bors
auto merge of #16468 : pcwalton/rust/as-renaming-import, r=alexcrichton
f8e0ede 
The old syntax will be removed after a snapshot.

RFC #47.

Issue #16461.

r? @brson
@pnkfelix
Copy link
Member

P-backcompat-lang, 1.0 milestone.

@pnkfelix pnkfelix added this to the 1.0 milestone Aug 14, 2014
pcwalton added a commit to pcwalton/rust that referenced this issue Aug 18, 2014
@pcwalton
libsyntax: Remove the use foo = bar syntax from the language in favor
67deb2e 
of `use bar as foo`.

Change all uses of `use foo = bar` to `use bar as foo`.

Implements RFC rust-lang#47.

Closes rust-lang#16461.

[breaking-change]
@pcwalton pcwalton mentioned this issue Aug 18, 2014
Merged
bors added a commit that referenced this issue Aug 18, 2014
@bors
auto merge of #16575 : pcwalton/rust/import-foo-as-bar, r=aturon
98ec85f 
of `use bar as foo`.

Change all uses of `use foo = bar` to `use bar as foo`.

Implements RFC #47.

Closes #16461.

[breaking-change]

r? @aturon
@liigo
Copy link
Contributor

liigo commented Aug 21, 2014

extern crate "string_literal" as ident is included in RFC 47 too, but it has not been implemented yet. Keep this issue open or create a new one?

@pnkfelix
Copy link
Member

@liigo good point, reopening.

@pnkfelix pnkfelix reopened this Aug 22, 2014
@wickerwaka wickerwaka mentioned this issue Aug 23, 2014
Merged
wickerwaka pushed a commit to wickerwaka/rust that referenced this issue Aug 23, 2014
extern crate foobar as foo;
c0e003d 
Implements remaining part of RFC rust-lang#47.
Addresses issue rust-lang#16461.

Removed link_attrs from rust.md, they don't appear to be supported by
the parser.

Changed all the tests to use the new extern crate syntax

Change pretty printer to use 'as' syntax
bors added a commit that referenced this issue Aug 27, 2014
@bors
auto merge of #16689 : wickerwaka/rust/crate-as, r=pcwalton
5550ede 
For review. Not sure about the link_attrs stuff. Will work on converting all the tests.

extern crate "foobar" as foo;
extern crate foobar as foo;

Implements remaining part of RFC #47.
Addresses issue #16461.

Removed link_attrs from rust.md, they don't appear to be supported by
the parser.
@pcwalton pcwalton mentioned this issue Sep 6, 2014
Merged
pcwalton added a commit to pcwalton/rust that referenced this issue Sep 10, 2014
@pcwalton
librustc: Obsolete the old external crate renaming syntax.
1bce869 
Instead of `extern crate foo = bar`, write `extern crate bar as foo`.
Instead of `extern crate baz = "quux"`, write `extern crate "quux" as
baz`.

Closes rust-lang#16461.

[breaking-change]
bors added a commit that referenced this issue Sep 10, 2014
@bors
auto merge of #17048 : pcwalton/rust/remove-old-import-renaming-synta…
036f380 
…x, r=brson

Instead of `extern crate foo = bar`, write `extern crate bar as foo`.
Instead of `extern crate baz = "quux"`, write `extern crate "quux" as
baz`.

Closes #16461.

[breaking-change]

r? @brson
ankurp added a commit to ankurp/rust-ws that referenced this issue Sep 14, 2014
@ankurp
Rust syntax update - rust-lang/rust#16461
f2af37e
@ankurp ankurp mentioned this issue Sep 14, 2014
Closed
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Feb 5, 2024
@bors
Auto merge of rust-lang#16461 - Veykril:expansion-info, r=Veykril
2661c27 
internal: Remove unnecessary usages of ExpansionInfo

And some follow up simplifications to rust-lang/rust-analyzer#16439
BlockBlazeDev added a commit to BlockBlazeDev/rust-crypto that referenced this issue Aug 8, 2024
@BlockBlazeDev
Update for Rust syntax changes
f4844df 
extern crate foo = "bar";
is now
extern crate "bar" as foo;
as per RFC 47.  Details at rust-lang/rust#16461
cosmycoder added a commit to cosmycoder/rust-crypto that referenced this issue Sep 5, 2024
@cosmycoder
Update for Rust syntax changes
984c37d 
extern crate foo = "bar";
is now
extern crate "bar" as foo;
as per RFC 47.  Details at rust-lang/rust#16461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
4 participants
@brson @nikomatsakis @pnkfelix @liigo