-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit reference manual before 1.0 #16676
Comments
Very yes. |
I'm going to assign this to myself, as we decided at the work week, but I will be working with/delegating to others on actually carrying this out. |
Re-nominating. Should this be on the beta milestone? |
leaving on the 1.0 milestone; this is considered polish, after we've finished all the backwards incompat stuff. |
Audited section 5, Crates and source files. Filed PR #24727 to fix it. |
I'm reading 8.1, the types chapter. PR #24744 I didn't really cover 8.1.13 Self types, someone should look at that again. |
EDIT: Let me rescind that—I'm told that, as the unit type is no longer viewed as being separate from the tuple, the reference is going to need a bit more of an overhaul than what I've done in the PR, including possibly taking out the section I've edited. |
Audited 3.3 (Comments). Filed #24740 for a small clarification. Aside from that it looks good, although I think the EBNF is a little sketchy. ( |
Audited 3.5.1 (Keywords). Filed #24742 to add two missing keywords. |
6.1.4 (Type Aliases) looks good to me. |
#24753 - describe Range expressions |
If the unit type is no longer present, will unit-like structs be renamed to something else? |
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
I read: 4 Syntax extensions
Directly used as this in a macro fails, because it's not actually |
Thanks @badboy ! I believe you are right, would you mind sending a PR? |
Will do |
@steveklabnik read through some of chapter 7, wouldn't want to greenlight it yet but found what I think is a small issue and made a pr: #25286 |
Audited as ok:
Pending PR #25290 to fix:
|
Since #24863 was merged, all of 3.5.2 can be marked as done (sorry bluss for letting you repeat work) |
Well since I read the fixed version it was easy :) |
I read 6.1.9 (and part of 8.1.11) and submitted a PR: #25308 |
…chton As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct. I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
…chton As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct. I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
I'm considering this closed, as both @nikomatsakis and I did a full read-over, and the community chipped in a ton as well. Future improvements to the reference are always welcome, of course. |
The "unit value" is a value of the "unit type," not the "unit value type." Regardless of correctness, this straight syntax is easier to grok. Part of #16676 Sorry if something's off here, it's my first pull request to rust!
Changed in rust-lang#22838. audited (raw) byte string literals @ rust-lang#16676
Shortly before 1.0 we should give some attention to the manual and make sure it's not too inaccurate nor incomplete.
Let's crowdsource this edit! Please check one of these sections, and leave a comment below if you've verified that it's accurate or have sent a PR fixing part:
The text was updated successfully, but these errors were encountered: