Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conventions for ownership variants #16810

Closed
alexcrichton opened this issue Aug 28, 2014 · 1 comment · Fixed by #17268
Closed

Implement conventions for ownership variants #16810

alexcrichton opened this issue Aug 28, 2014 · 1 comment · Fixed by #17268
Assignees
@aturon
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@alexcrichton
Copy link
Member

Tracking RFC for rust-lang/rfcs#199
@aturon aturon self-assigned this Aug 28, 2014
@aturon
Copy link
Member

aturon commented Aug 28, 2014

cc #13660

@aturon aturon mentioned this issue Sep 15, 2014
Merged
bors added a commit that referenced this issue Sep 16, 2014
@bors
auto merge of #17268 : aturon/rust/mut-conventions, r=alexcrichton
c378e65 
As per [RFC 52](https://github.com/rust-lang/rfcs/blob/master/active/0052-ownership-variants.md), use `_mut` suffixes to mark mutable variants, and `into_iter` for moving iterators. Additional details and motivation in the RFC.

Note that the iterator *type* names are not changed by this RFC; those are awaiting a separate RFC for standardization.

Closes #13660
Closes #16810

[breaking-change]
bors added a commit that referenced this issue Sep 16, 2014
@bors
auto merge of #17268 : aturon/rust/mut-conventions, r=alexcrichton
0e784e1 
As per [RFC 52](https://github.com/rust-lang/rfcs/blob/master/active/0052-ownership-variants.md), use `_mut` suffixes to mark mutable variants, and `into_iter` for moving iterators. Additional details and motivation in the RFC.

Note that the iterator *type* names are not changed by this RFC; those are awaiting a separate RFC for standardization.

Closes #13660
Closes #16810

[breaking-change]
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 17, 2024
@bors
Auto merge of rust-lang#16810 - Young-Flash:unused_var_fix, r=Veykril
40ee359 
feat: add fix for unused_variables

add a leading underscore for unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aturon aturon

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align APIs with new _mut conventions aturon/rust
2 participants
@alexcrichton @aturon