Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the "periodic table" into the official docs #16960

Closed
nodakai opened this issue Sep 3, 2014 · 12 comments
Closed

Include the "periodic table" into the official docs #16960

nodakai opened this issue Sep 3, 2014 · 12 comments

Comments

@nodakai
Copy link
Contributor

nodakai commented Sep 3, 2014

Why don't you officially include this excellent "periodic table of Rust types" into, say, the top of the pointer guide? (It's under cc-by-4.0.)

@brson
Copy link
Contributor

brson commented Sep 5, 2014

I am a big fan of this work and would be happy to link to it somewhere prominent, and potentially even pull it into tree.

cc @steveklabnik

@brson brson added the A-docs label Sep 5, 2014
@huonw
Copy link
Member

huonw commented Sep 5, 2014

cc @lifthrasiir

(It's awesome that the two 'proposed' features there are now in the compiler!)

@steveklabnik
Copy link
Member

I like it and I don't. I think it's useful, but it was also used as a 'OMG Rust is so complex'.

I'd imagine that it'd go in the Manual somewhere.=

@aturon
Copy link
Member

aturon commented Sep 5, 2014

Wow, I love this, and would love to see it pulled into official docs in some way.

@Kimundi
Copy link
Member

Kimundi commented Sep 5, 2014

While I like the table, I think it needs to be refactored a bit now that the two proposed features landed. Specifically, DST and function types could get de-emphasize and move into a auxiliary table of common type combinations.

@lifthrasiir
Copy link
Contributor

I share the same feeling with @steveklabnik, that the table may possibly discourage new users without further tweaks. I have no problem with refactoring or tweaking the table, so feel free to experiment with it. :)

Some concern about licensing: is CC-by 4.0 compatible with the current documentation license (Apache 2.0 or MIT)? I guess so, but of course IANAL.

@steveklabnik
Copy link
Member

This table is now out of date. Is this worth trying to resurrect? I still have complexity worry here.

@sinistersnare
Copy link
Contributor

Regardless if it is included or not, I would love to see it updated for DST and unboxed closures to be ticked on by default (or remove the boxes because they are permanent)

@lifthrasiir
Copy link
Contributor

I currently have no good idea to restructure the table, but don't mind if there is a contribution. I'll at least mark the page as outdated. I've updated the table to at least reflect the status quo for 1.0.0-alpha.

@sinistersnare
Copy link
Contributor

Does the page have a source repo? Or is it only just a single html page?

@lifthrasiir
Copy link
Contributor

@sinistersnare It's a single page (including the CSS) sans a small PNG file.

@steveklabnik
Copy link
Member

After thinking about this a long time, I'm not sure where it goes, I'm afraid of the perception of complexity, and so I'm going to just give this a close. Thanks.

bors added a commit to rust-lang-ci/rust that referenced this issue Mar 31, 2024
fix: lifetime length are not added in count of params in highlight

I found these two instances easily but I wonder how many such instances are there.

Fixes rust-lang#16958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants