Skip to content

Cycle time has regressed by 30 mins #17183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Sep 12, 2014 · 4 comments · Fixed by #17256
Closed

Cycle time has regressed by 30 mins #17183

alexcrichton opened this issue Sep 12, 2014 · 4 comments · Fixed by #17256

Comments

@alexcrichton
Copy link
Member

The android builders (the slowest ones) have slowed down by an extra half hour.

The test step is taking a half hour longer because it's rebuilding everything which was previously built. Looking at the history it looks like #17095 introduced the regression, so it looks like something is going wrong with rebuilding jemalloc (starting the whole build process over again).

cc @thestinger
@alexcrichton
Copy link
Member Author

Looking at the relevant target, perhaps jemalloc is touching files in the source directory?

@brson
Copy link
Contributor

brson commented Sep 12, 2014

Any progress on this?

@alexcrichton
Copy link
Member Author

It appears that jemalloc is touching a file called VERSION at the root of the source tree as part of the configure step.

This is causing the target to be rebuilt on android because the VERSION file is touched twice, once for the host arch and one for android. Touching it a second time when building android invalidates the previously built host artifacts, triggering the entire recompilation.

@alexcrichton
Copy link
Member Author

relevant commit: jemalloc/jemalloc@a5a658a

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 14, 2014
@alexcrichton
mk: Don't depend on src/jemalloc/VERSION
134c1e9 
This file is touched during the build process and will trigger more rebuilds
than necessary.

Closes rust-lang#17183
@alexcrichton alexcrichton mentioned this issue Sep 14, 2014
Merged
bors added a commit that referenced this issue Sep 15, 2014
@bors
auto merge of #17256 : alexcrichton/rust/issue-17183, r=sfackler
3e7e2af 
This file is touched during the build process and will trigger more rebuilds
than necessary.

Closes #17183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mk: Don't depend on src/jemalloc/VERSION alexcrichton/rust
2 participants
@alexcrichton @brson