Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heap: align > MIN_ALIGN can trigger undefined behavior #17207

Closed
thestinger opened this issue Sep 12, 2014 · 5 comments
Closed

heap: align > MIN_ALIGN can trigger undefined behavior #17207

thestinger opened this issue Sep 12, 2014 · 5 comments
Labels
A-allocators Area: Custom and system allocators I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@thestinger
Copy link
Contributor

The non-standard jemalloc API makes dealing with this into the caller's problem.
@thestinger thestinger mentioned this issue Sep 12, 2014
Closed
@thestinger thestinger changed the title align > MIN_ALIGN can trigger undefined behavior heap: align > MIN_ALIGN can trigger undefined behavior Sep 12, 2014
@thestinger thestinger added the A-allocators Area: Custom and system allocators label Sep 16, 2014
@steveklabnik
Copy link
Member

Triage: we have recently updated to jemallc 4.0.0, but we still may want to worry about this.

@steveklabnik steveklabnik added I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 8, 2017
@steveklabnik
Copy link
Member

Triage: not aware of any changes here. Tagging as "unsound" and for the libs team, as this would be their issue.

@Mark-Simulacrum
Copy link
Member

Nominating for discussion by libs team since this is apparently unsound; so we should at least get eyes on it.

@alexcrichton alexcrichton mentioned this issue Jun 6, 2017
Merged
10 tasks
@alexcrichton
Copy link
Member

Discussed during libs triage today, this is mostly relevant for #32838 now and I've left a comment on the associated PR explaining how this is relevant. This will likely get closed in time as the allocator trait lands, stabilizes, and we audit various locations in libstd.

@alexcrichton
Copy link
Member

This was handled as part of #42313, so closing.

lnicola pushed a commit to lnicola/rust that referenced this issue May 19, 2024
@bors
Auto merge of rust-lang#17207 - Wilfred:serde_invalid_data, r=lnicola
85b17d4 
fix: Report all LSP protocol errors with invalid_data

Previously we did not use invalid_data for serde errors, making it harder to understand errors when the client sends malformed data to the server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-allocators Area: Custom and system allocators I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @alexcrichton @thestinger @Mark-Simulacrum