Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the slice methods from ops::Slice with methods in core::slice #17273

Closed
nrc opened this issue Sep 15, 2014 · 3 comments
Closed

Merge the slice methods from ops::Slice with methods in core::slice #17273

nrc opened this issue Sep 15, 2014 · 3 comments
Assignees
@nrc

Comments

@nrc
Copy link
Member

nrc commented Sep 15, 2014

Needs a snapshot so we can use indexing, otherwise there's a bunch of changes to something ugly which will change again post-snapshot.
@nrc
Copy link
Member Author

nrc commented Sep 16, 2014

This entails changing all the uses of slice/slice_from/etc. to using the slicing sugar

@nrc nrc mentioned this issue Sep 16, 2014
Closed
@nrc
Copy link
Member Author

nrc commented Sep 17, 2014

This includes removing the offensive _s from the Slice methods

@nrc nrc mentioned this issue Sep 17, 2014
Merged
@nrc
Copy link
Member Author

nrc commented Sep 28, 2014

I am working on this

@nrc nrc self-assigned this Sep 28, 2014
nrc added a commit to nrc/rust that referenced this issue Sep 29, 2014
@nrc
Remove the _ suffix from slice methods.
f464132 
Deprecates slicing methods from ImmutableSlice/MutableSlice in favour of slicing syntax or the methods in Slice/SliceMut.

Closes rust-lang#17273.
nrc added a commit to nrc/rust that referenced this issue Sep 30, 2014
@nrc
Remove the _ suffix from slice methods.
dfef56a 
Deprecates slicing methods from ImmutableSlice/MutableSlice in favour of slicing syntax or the methods in Slice/SliceMut.

Closes rust-lang#17273.
@nrc nrc closed this as completed in df2f1fa Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrc