Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows nightly installer does not update %PATH% #17570

Closed
iliekturtles opened this issue Sep 26, 2014 · 1 comment · Fixed by #17573
Closed

Windows nightly installer does not update %PATH% #17570

iliekturtles opened this issue Sep 26, 2014 · 1 comment · Fixed by #17573

Comments

@iliekturtles
Copy link
Contributor

The Rust nightly Windows installer, rust-nightly-i686-w64-mingw32.exe adds C:\Program Files (x86)\Rust\bin to the current user's path. Because the installer immediately requests to be elevated upon execution this will be an administrator that may not be the original user who ran the installer.

Because the installer defaults to Program Files (x86) I believe that the installer should update the system path as this is generally expected for Windows programs that require an elevated installer. I will submit a patch to make this change shortly.

If it is still desired to change the current user's path I suggest making this an option. I did some brief research on how to get the setup application to make changes for the current user, but didn't see any quick fixes.

@iliekturtles iliekturtles mentioned this issue Sep 26, 2014
33 tasks
iliekturtles added a commit to iliekturtles/rust that referenced this issue Sep 26, 2014
Modify the system %PATH% environment variable instead of the current
user's %PATH% environment. The current user will be an admin user
that may not be the same user who originally started the installer.
Closes rust-lang#17570.
@brson
Copy link
Contributor

brson commented Oct 8, 2014

@iliekturtles Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants