Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no way to make uninitialized global variables #17571

Closed
thestinger opened this issue Sep 26, 2014 · 2 comments
Closed

no way to make uninitialized global variables #17571

thestinger opened this issue Sep 26, 2014 · 2 comments
Labels
A-codegen Area: Code generation C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

Even if there was CTFE, unsafe functions like mem::uninitialized probably wouldn't be permitted.
@thestinger thestinger added I-slow Issue: Problems and improvements with respect to performance of generated code. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-codegen Area: Code generation labels Sep 26, 2014
@thestinger thestinger mentioned this issue Sep 26, 2014
Closed
@thestinger
Copy link
Contributor Author

I figured out how to work around this issue for TLS, so I'll just open an RFC for this as having it behind a feature gate for TLS doesn't appear to be necessary.

@thestinger
Copy link
Contributor Author

rust-lang/rfcs#411

lnicola pushed a commit to lnicola/rust that referenced this issue Jul 11, 2024
@bors
Auto merge of rust-lang#17571 - winstxnhdw:bool-to-enum-no-dupe, r=Ve…
45609a9 
…ykril

feat: do not add new enum if it already exists

## Summary

This PR introduces a check for the existence of another enum within the current scope, and if it exist, we skip `add_enum_def`.

## Why?

Currently, when using the `bool_to_enum` assist more than once, it is possible to add multiple enum definitions. For example, the following snippet,

```rs
#[derive(PartialEq, Eq)]
enum Bool {
    True,
    False,
}

fn main() {
    let a = Bool::True;
    let b = true;
    println!("Hello, world!");
}
```

will be transformed into,

```rs
#[derive(PartialEq, Eq)]
enum Bool {
    True,
    False,
}

#[derive(PartialEq, Eq)]
enum Bool {
    True,
    False,
}

fn main() {
    let a = Bool::True;
    let b = Bool::True;
    println!("Hello, world!");
}
```

This can be annoying for users to clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thestinger