Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prev_permutation / next_permutation and the Permutations iterator should be in libcore #17917

Closed
thestinger opened this issue Oct 10, 2014 · 0 comments · Fixed by #18559
Closed

prev_permutation / next_permutation and the Permutations iterator should be in libcore #17917

thestinger opened this issue Oct 10, 2014 · 0 comments · Fixed by #18559
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@thestinger
Copy link
Contributor

There's no reason for these to be in the collections crate as they only require Ord. The MutableOrdSlice trait will need to be split up since the current sort implementation uses memory allocation.
@thestinger thestinger added A-libs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Oct 10, 2014
@thestinger thestinger changed the title prev_permutation / next_permutation should be in libcore prev_permutation / next_permutation and the Permutations iterator should be in libcore Oct 10, 2014
@aturon aturon mentioned this issue Nov 5, 2014
Merged
aturon added a commit to aturon/rust that referenced this issue Nov 6, 2014
@aturon
Prelude: rename and consolidate extension traits
cfafc1b 
This commit renames a number of extension traits for slices and string
slices, now that they have been refactored for DST. In many cases,
multiple extension traits could now be consolidated. Further
consolidation will be possible with generalized where clauses.

The renamings are consistent with the [new `-Prelude`
suffix](rust-lang/rfcs#344). There are probably
a few more candidates for being renamed this way, but that is left for
API stabilization of the relevant modules.

Because this renames traits, it is a:

[breaking-change]

However, I do not expect any code that currently uses the standard
library to actually break.

Closes rust-lang#17917
bors added a commit that referenced this issue Nov 6, 2014
@bors
auto merge of #18559 : aturon/rust/prelude_cleanup, r=alexcrichton
8ed288e 
This commit renames a number of extension traits for slices and string slices, now that they have been refactored for DST. In many cases, multiple extension traits could now be consolidated. Further consolidation will be possible with generalized where clauses.

The renamings are consistent with the [new `-Prelude` suffix](rust-lang/rfcs#344). There are probably a few more candidates for being renamed this way, but that is left for API stabilization of the relevant modules.

Because this renames traits, it is a:

[breaking-change]

However, I do not expect any code that currently uses the standard library to actually break.

Closes #17917
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
@bors
Auto merge of rust-lang#17917 - ShoyuVanilla:pin-rowan, r=lnicola
d2d41b4 
Pin `rowan` to `0.15.15`

To prevent rust-lang#17914, I think that it would be safer pinning this before we fix it correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prelude: rename and consolidate extension traits aturon/rust
1 participant
@thestinger