Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc.exe does not reset PowerShell colors after compilation error #17982

Closed
amckinlay opened this issue Oct 12, 2014 · 0 comments
Closed

rustc.exe does not reset PowerShell colors after compilation error #17982

amckinlay opened this issue Oct 12, 2014 · 0 comments
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler O-windows Operating system: Windows

Comments

@amckinlay
Copy link

Version

PS C:\Users\Andrew McKinlay> rustc -v
rustc 0.12.0 (ba4081a5a 2014-10-07 13:44:41 -0700)

(I believe this issue occurs in the nightly, too)

Problem

Related issues

#17416?
@kmcallister kmcallister added O-windows Operating system: Windows A-driver Area: rustc_driver that ties everything together into the `rustc` compiler I-papercut labels Oct 13, 2014
vadimcn added a commit to vadimcn/rust that referenced this issue Oct 26, 2014
@vadimcn
Fix bug rust-lang#17982.
f29535d
@bors bors closed this as completed in e23f5c8 Nov 3, 2014
lnicola pushed a commit to lnicola/rust that referenced this issue Sep 25, 2024
@bors
Auto merge of rust-lang#17982 - IvarWithoutBones:generate-impl-indent…
16a29ce 
…, r=Veykril

fix: consider indentation in the "Generate impl" and "Generate trait impl" assists

This makes the generated impl's indentation match the ADT it targets, improving formatting when using nested modules inside of the same file or when defining types inside of a function. See the added tests for an example.

At first I tried to call some of the convenient helpers that delegate to `IndentLevel::increase_indent` on the generated impl, but as the comment on that function notes it does not indent the first token, making it inapplicable here. I hope the solution in this PR is acceptable, please let me know if I missed something :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmcallister @amckinlay