Skip to content

Investigate LLVM support for huge objects #18069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arielb1 opened this issue Oct 15, 2014 · 1 comment · Fixed by #18728
Closed

Investigate LLVM support for huge objects #18069

arielb1 opened this issue Oct 15, 2014 · 1 comment · Fixed by #18728
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@arielb1
Copy link
Contributor

arielb1 commented Oct 15, 2014

LLVM does not support objects larger than 1<<61 bytes, because it represents sizes as u64 counts of bits.

Currently, to be safe, I'm blocking compile-time objects bigger than 2 GiB (in case LLVM uses an int count of bytes somewhere). It would be nice to find out how much can we increase this, especially on 64-bit targets.
@arielb1 arielb1 mentioned this issue Oct 16, 2014
Closed
@kmcallister kmcallister added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Oct 16, 2014
@thestinger thestinger mentioned this issue Nov 7, 2014
Merged
@arielb1
Copy link
Contributor Author

arielb1 commented Nov 8, 2014

#18728 bounds object size by 2 GiB on 32-bit architectures and 128 TiB (1<<47) on 64-bit architectures.

bors added a commit that referenced this issue Nov 19, 2014
@bors
auto merge of #18728 : thestinger/rust/int, r=cmr
a24b444 
This fixes the gap in the language definition causing #18726 by defining
a clear bound on the maximum size for libraries to enforce.

Closes #18069
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@thestinger @Manishearth
clearly define int and uint to fix unsoundness
3ac34fc 
This fixes the gap in the language definition causing rust-lang#18726 by defining
a clear bound on the maximum size for libraries to enforce.

Closes rust-lang#18069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix maximum object size semantics
2 participants
@kmcallister @arielb1