Mark lt from PartialOrd as inline

[ghost]

pub trait PartialOrd: PartialEq {
    /// This method returns an ordering between `self` and `other` values
    /// if one exists.
    fn partial_cmp(&self, other: &Self) -> Option<Ordering>;

    /// This method tests less than (for `self` and `other`) and is used by the `<` operator.
    fn lt(&self, other: &Self) -> bool { ... }

    /// This method tests less than or equal to (`<=`).
    #[inline]
    fn le(&self, other: &Self) -> bool { ... }

    /// This method tests greater than (`>`).
    #[inline]
    fn gt(&self, other: &Self) -> bool { ... }

    /// This method tests greater than or equal to (`>=`).
    #[inline]
    fn ge(&self, other: &Self) -> bool { ... }
}

Shouldn't the lt method also be inline?

[nodakai]

Before partial_cmp() was introduced, PartialOrd required only lt() and defined le(), gt() and ge() in terms of it. I agree now it should be #[inline], too.

[Gankra]

(or that none of them should be inline, the eternal struggle)

[rclanan]

On this same note, should eq also be marked as inline? On line 318 in cmp.rs it is but elsewhere it isn't.

rust/src/libcore/cmp.rs

Line 318 in 3be6a2f

fn eq(&self, _other: &()) -> bool { true }

[gamazeps]

it already is ;)

[rclanan]

Not on this line:

rust/src/libcore/cmp.rs

Line 61 in 3be6a2f

fn eq(&self, other: &Self) -> bool;

[Gankra]

@rclanan The line you link is just a function delcaration, and not a function itself. I don't think you can (meaningfully) declare such a thing as #[inline].

[rclanan]

Awesome, thanks for the feedback! I was just going based on what I saw on line 65 but I see the difference now.