Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When UdpStream receives a message from the wrong sender, it returns Ok(0), #18111

Closed
mahkoh opened this issue Oct 17, 2014 · 0 comments · Fixed by #18130
Closed

When UdpStream receives a message from the wrong sender, it returns Ok(0), #18111

mahkoh opened this issue Oct 17, 2014 · 0 comments · Fixed by #18130

Comments

@mahkoh
Copy link
Contributor

mahkoh commented Oct 17, 2014

change this to something more appropriate.

This was introduced in commit ac49b74 when read still returned Option.

This should either block until a message from the correct sender arrives or return an error.
bors added a commit that referenced this issue Oct 27, 2014
@bors
auto merge of #18130 : mahkoh/rust/udp, r=alexcrichton
a93e9c2 
Closes #18111

Note that the non-empty part doesn't matter right now because of #18129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make UdpStream block until the next non-empty msg and deprecate it.
1 participant
@mahkoh