Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lints: no way to mark stability of deriving #18969

Closed
aturon opened this issue Nov 15, 2014 · 2 comments
Closed

lints: no way to mark stability of deriving #18969

aturon opened this issue Nov 15, 2014 · 2 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@aturon
Copy link
Member

aturon commented Nov 15, 2014

There is currently no way to give the stability level of an impl provided by #[deriving(Foo)].
@alexcrichton
Copy link
Member

cc #13054, one possible method

@emberian emberian mentioned this issue Dec 26, 2014
Closed
@sanxiyn sanxiyn added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Jan 27, 2015
@aturon aturon mentioned this issue Feb 16, 2015
Closed
@petrochenkov petrochenkov mentioned this issue Oct 18, 2015
Merged
bors added a commit that referenced this issue Oct 20, 2015
@bors
Auto merge of #29152 - petrochenkov:derstab, r=alexcrichton
db54339 
The attributes are copied from the item for which the trait impl is derived

I think now we can close these two issues:
#13054 - `allow`, `deny` etc. were already copied, now `stable` and `unstable` are copied as well.
#18969 - I'm not sure this is needed, insta-stability were good enough so far, copied stability will be better. Nonetheless, it can be subsumed by some more general mechanism for supplying arbitrary not necessarily stability related attributes (for example `inline`) to derived impls and their methods (I haven't found an open issue for such mechanism).

r? @alexcrichton
@petrochenkov
Copy link
Contributor

Was resolved by #29152
Arbitrary attributes on derived impls is a separate problem

@petrochenkov petrochenkov mentioned this issue Nov 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

syntax: allow setting attributes for deriving impls
5 participants
@sanxiyn @alexcrichton @aturon @sfackler @petrochenkov