Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stability and benchmark metric infrastructure #19145

Closed
brson opened this issue Nov 20, 2014 · 7 comments · Fixed by #20230 or #21503
Closed

Remove stability and benchmark metric infrastructure #19145

brson opened this issue Nov 20, 2014 · 7 comments · Fixed by #20230 or #21503
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Nov 20, 2014

We generate this information and upload it and do nothing with it (and the upload causes #19079). Let's just completely remove the code for it (including the never-used ratcheting feature, and probably the test-sharding feature as well).
@brson brson added A-testsuite Area: The testsuite used to check the correctness of rustc A-infrastructure labels Nov 20, 2014
This was referenced Nov 20, 2014
Closed
Closed
@brson
Copy link
Contributor Author

brson commented Dec 14, 2014

Nominating because this adds --save-metrics and --ratchet-metrics to test runners that I don't want to support.

@steveklabnik
Copy link
Member

I left the documentation about saving and ratcheting metrics out of the latest iteration of the testing guide, so agreed there.

@brson
Copy link
Contributor Author

brson commented Dec 16, 2014

Bots are no longer uploading metrics so it's safe to remove from the code.

@pnkfelix
Copy link
Member

P-backcompat-libs, 1.0.

@pnkfelix pnkfelix added this to the 1.0 milestone Dec 18, 2014
@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Dec 18, 2014
@bheesham bheesham mentioned this issue Dec 20, 2014
Merged
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Dec 21, 2014
Took out all of the metrics stuff from tests.mk
611ef49 
References rust-lang/rust/rust-lang#19145

	modified:   src/llvm (new commits)
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 21, 2014
@alexcrichton
rollup merge of rust-lang#20054: bheesham/nomet
7e62684 
rust-lang#19145
@bheesham bheesham mentioned this issue Dec 25, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 30, 2014
@alexcrichton
rollup merge of rust-lang#20230: bheesham/noshard
bcd3b16 
I forgot to do this in my previous PR. This should close rust-lang#19145 .
@brson brson reopened this Jan 5, 2015
@brson
Copy link
Contributor Author

brson commented Jan 5, 2015

Only the stuff in tests.mk has been removed. The test crate still supports a bunch of stuff that should be removed. Here are my suggestions:

  • save-metrics - remove
  • ratchet-metrics - remove
  • ratchet-noise-percent - remove
  • test-shard - remove
  • boxplot - remove
  • boxplot-width - remove
  • stats - remove

boxplot and stats are less obvious.

@ahmedcharles
Copy link
Contributor

I'm working on removing these. It's just taking a little while to get familiar with the code.

This was referenced Jan 20, 2015
Merged
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 21, 2015
@alexcrichton
rollup merge of rust-lang#21413: ahmedcharles/remove-test-features
81504f2 
This isn't the entire set of changes, there are more coming. rust-lang#19145
@ahmedcharles ahmedcharles mentioned this issue Jan 22, 2015
Merged
bors added a commit that referenced this issue Jan 23, 2015
@bors
Auto merge of #21503 - ahmedcharles:remove-test-features, r=alexcrichton
4be79d6 
I think this is all of the remaining code to be removed. Let me know if I've missed anything.

Closes #19145
aroben added a commit to aroben/html5ever that referenced this issue Jan 27, 2015
@aroben
Update for removal of --save-metrics flag from libtest
22a97c2 
See rust-lang/rust#19145.
@kmcallister
Copy link
Contributor

Does this live on somewhere out-of-tree? I was using it in html5ever.

@kennytm kennytm mentioned this issue Dec 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Removed the sharding bit from mk/tests.mk
Remove remaining test features.
5 participants
@steveklabnik @brson @pnkfelix @kmcallister @ahmedcharles