Skip to content

Trans uses more stack when things are made private #19497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nikomatsakis opened this issue Dec 3, 2014 · 2 comments
Closed

Trans uses more stack when things are made private #19497

nikomatsakis opened this issue Dec 3, 2014 · 2 comments
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@nikomatsakis
Copy link
Contributor

In my "cratification" PR, I have been making things aggressively private. This causes stack overflow. It's weird.
nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Dec 3, 2014
@nikomatsakis
FIXME(rust-lang#19497) -- Stop messing around and just give rustc 32M…
39eed46 
…B of stack unconditionally. This is prompted by some sort of bug in trans that causes a stack overflow when the modules in trans are made private. (In particular, the overflow can also be avoided by making `controlflow` and `callee` public, but that seems strictly worse than just using more stack.)
nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Dec 4, 2014
@nikomatsakis
FIXME(rust-lang#19497) -- Stop messing around and just give rustc 32M…
5d19432 
…B of stack unconditionally. This is prompted by some sort of bug in trans that causes a stack overflow when the modules in trans are made private. (In particular, the overflow can also be avoided by making `controlflow` and `callee` public, but that seems strictly worse than just using more stack.)
@kmcallister kmcallister added A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ labels Jan 25, 2015
@tamird
Copy link
Contributor

tamird commented Apr 22, 2015

Is there an action here?

@steveklabnik steveklabnik mentioned this issue Oct 23, 2015
Closed
@steveklabnik
Copy link
Member

Apparently not :)

@nikomatsakis let me know if you still want this open for some reason.

lnicola pushed a commit to lnicola/rust that referenced this issue Apr 28, 2025
@ChayimFriedman2
Fix a bug in MBE expansion that arose from incorrect fixing of an old…
6bb0904 
…er bug in MBE

Specifically, rust-lang#18744 was the PR that was supposed to fix the old bug, but it fixed it incorrectly (and didn't add a test!) The underlying reason was that we marked metavariables in expansions as joint if they were joint in the macro call, which is incorrect.

This wrong fix causes other bug, rust-lang#19497, which this PR fixes by removing the old (incorrect) fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @nikomatsakis @kmcallister @tamird