Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust requires llvm.assume intrinsic and hence LLVM 3.6 #20010

Closed
anguslees opened this issue Dec 19, 2014 · 6 comments
Closed

Rust requires llvm.assume intrinsic and hence LLVM 3.6 #20010

anguslees opened this issue Dec 19, 2014 · 6 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@anguslees
Copy link
Contributor

The rust ./configure LLVM version check is only for 3.[2-6], yet #18080 adds a requirement on llvm.assume intrinsic. This intrinsic only appears in LLVM 3.6.

I think the version check needs to be updated accordingly - or only use the new optimisation intrinsic conditionally on building against newer LLVM.
@sanxiyn
Copy link
Member

sanxiyn commented Dec 19, 2014

FYI, minimal LLVM version was last updated in #5813. The reason was to support inline assembly.

@kmcallister kmcallister added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-build labels Jan 16, 2015
@lucab
Copy link
Contributor

lucab commented Jan 19, 2015

Just as a note, current rust also fails to build against latest (external) stable LLVM 3.5.1 due to a newer EngineBuilder() signature picked-up by rustllvm/ExecutionEngineWrapper.cpp.
I didn't follow latest discussion about tracking LLVM releases, but I think the timing is good to decide which LLVM releases we want to target with 1.0.

@lucab
Copy link
Contributor

lucab commented Jan 22, 2015

Some discussion on this at http://discuss.rust-lang.org/t/targeted-llvm-for-1-0/1371/1. I may give a shot at this if I have some time.

@lucab lucab mentioned this issue Jan 24, 2015
Closed
@tamird
Copy link
Contributor

tamird commented May 30, 2015

Can this be closed now that LLVM 3.5.2 is out?

@anguslees
Copy link
Contributor Author

rustc needs at least LLVM 3.6 rc4 (afaik).

This issue is regarding the LLVM version check in ./configure, which is still 3.[2-6] (and the error message says "bad LLVM version: ... need >=3.0svn".

I believe the ./configure test should be tightened to >=3.6

tamird added a commit to tamird/rust that referenced this issue May 30, 2015
@tamird
Require LLVM 3.6
549715d 
Closes rust-lang#20010.
@tamird tamird mentioned this issue May 30, 2015
Closed
@sanxiyn
Copy link
Member

sanxiyn commented Oct 21, 2015

configure check was updated to >=3.5 in #23362 and it is still the case today. Rust successfully bootstraps against LLVM 3.5.2 release now.

@sanxiyn sanxiyn closed this as completed Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatibility fixes for LLVM 3.5 lucab/rust
Require LLVM 3.6 tamird/rust
5 participants
@sanxiyn @lucab @anguslees @kmcallister @tamird