start / generated C main is the wrong type

[comex]

fn lang_start(main: *const u8, argc: int, argv: *const *const u8) -> int {

This is the signature both required for start fns and given to the C main wrapper function generated by create_entry_fn in librustc_trans/trans/base.rs. But it's clearly the wrong type: argc and the return value should be c_int or i32, not int.

[brson]

I'd prefer any lang items to use rust types and for the compiler or libs to generate any potentially platform-specific code necessary to glue things together.

[tbu-]

If we have compiler glue anyway, argc should be usize.

I'm not so sure about the return type, i32 as default go-to integer might be fine here, I however don't see justification for isize.

[brson]

Let's just gate it until we can think harder.