Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mach #20235

Closed
Manishearth opened this issue Dec 26, 2014 · 9 comments
Closed

Switch to mach #20235

Manishearth opened this issue Dec 26, 2014 · 9 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.

Comments

@Manishearth
Copy link
Member

Using makefiles for testing is rather broken (for example, if you want to run a different test via TETNAME=foo make-check-stage2-runpass, you have to delete the runpass binary and re-call make).

I suggest we move as much of the testing and other infrastructure out into mach, Mozilla's supercharged-make-in-python. Servo has already made this switch and the workflow is much smoother. The ./mach build command can internally call configure/make (at least initially), and instead of setting environment variables for various test tweaks we can set command line flags.

If I get time I'd love to work on this, but I'd like to know if this is really wanted first :)

@emberian
Copy link
Member

How is the story on Windows?

@Manishearth
Copy link
Member Author

It's python. Works fine.

...though of course there will be some kinks along the way. Firefox uses some MozillaBuild stuff for windows deps — I don't think they have anything to do with the python stuff, but they might do something special — and Servo hasn't touched Windows :)

We'd need to add python as a dependency on windows and that's it as far as I can tell.

@emberian
Copy link
Member

Can it be used with only a python interpreter, and no other supporting programs, as installed from python.org?

@Manishearth
Copy link
Member Author

Hmm. Not sure, but Servo's version seems to be self-contained (all the deps seem to be in-tree)

@Manishearth
Copy link
Member Author

(Note: Either way I'm only considering this post-1.0)

@kmcallister kmcallister added A-build A-testsuite Area: The testsuite used to check the correctness of rustc E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 16, 2015
@alexispurslane
Copy link
Contributor

Should someone start working on this? It seems like this is an ancient issue.

@ranma42
Copy link
Contributor

ranma42 commented May 27, 2016

Is this superseded by #31590 (rustbuild) ?

@Manishearth
Copy link
Member Author

No, mach is more of a wrapper around cargo to provide utility shortcuts

@brson brson removed the E-tedious label Jun 27, 2016
@alexcrichton
Copy link
Member

Looking at this now, with rustbuild we're probably not going to switch to mach, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Development

No branches or pull requests

7 participants