-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rename target_word_size #20421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Seems like |
Do we want to do some transition period? I.e.
|
I doubt there are a significant number of users outside of the low-level standard libraries. Most of those (like big integers) are likely incorrect because they really do want the largest hardware integer type. |
@thestinger the problem here are not users outside, but the std itself. If we just rename the attribute to something else, the code will build with stage0 but not stage > 0 and were we to replace the use of attributes everywhere as well, compiler would not build with stage0. |
You don't necessarily need a period of time with support for both. You can either just stick both attributes on the types with one used at stage0 and one after, or use cfg_attr if you don't want the unused attribute warnings. |
Closes rust-lang#20421 [breaking-change]
Closes rust-lang#20421 [breaking-change] r? @brson
Was there a reason this didn't also adjust the json field name? |
@jmesmon None. You should fill a new issue about that. |
…et-pointer-width to match rust struct field Completes rust-lang#20421 (which renamed the struct field but not the json field) If you're using the json target specificating interface, this is potentially a: [breaking-change]
At the moment,
target_word_size
in conditional compilation attributes actually refers to pointer size. Since word size (or register size) and pointer size are different concepts, it should be renamed.The text was updated successfully, but these errors were encountered: