Skip to content

Stop saving floating point registers in __morestack #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 21, 2012 · 1 comment
Closed

Stop saving floating point registers in __morestack #2043

brson opened this issue Mar 21, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows I-slow Issue: Problems and improvements with respect to performance of generated code.
Milestone
old 1.0 milestone

Comments

@brson
Copy link
Contributor

brson commented Mar 21, 2012

They require 128 bytes of stack and account for a big chunk of the work. We started saving them because of #1388 but we should be able to acquire a new stack segment without using floating point registers. GCC doesn't save them.
@ghost ghost assigned brson Apr 19, 2012
@brson brson mentioned this issue Sep 23, 2012
Closed
@luqmana
Copy link
Member

luqmana commented Mar 17, 2013

I couldn't reproduce the weirdness in the test case from #1388 when I got rid of the saves.

@luqmana luqmana mentioned this issue Mar 17, 2013
Closed
bors added a commit that referenced this issue Apr 18, 2013
@bors
auto merge of #5418 : luqmana/rust/stack-float, r=brson
2a86485 
Like I commented in #2043, I can't reproduce the weirdness from #1388 on either mac or linux (x84_64) and pushing to try gives all green.

That's 128 less bytes to have to keep in the stack for every call to __morestack.
@luqmana luqmana closed this as completed Apr 21, 2013
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@zhassan-aws
Add missing bump for CBMC viewer version in kani-verifier package (ru…
c135fa9 
…st-lang#2043)
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@FlashWhite
fix typo (rust-lang#2043)
fc83e59 
line 320:
original: "valtree back a to MIR constant"
updated: "valtree back to a MIR constant"
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@FlashWhite
fix typo (rust-lang#2043)
7d61151 
line 320:
original: "valtree back a to MIR constant"
updated: "valtree back to a MIR constant"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@brson @luqmana