Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-fail/recursion.rs uses a dummy span with an expansion id of -2 #20747

Closed
Manishearth opened this issue Jan 8, 2015 · 3 comments · Fixed by #20808
Closed

compile-fail/recursion.rs uses a dummy span with an expansion id of -2 #20747

Manishearth opened this issue Jan 8, 2015 · 3 comments · Fixed by #20808
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@Manishearth
Copy link
Member

Found whilst testing #20032

From the test:

// We also get a second error message at the top of file (dummy
// span). This is not helpful, but also kind of annoying to prevent,
// so for now just live with it, since we also get a second message
// that is more helpful.

This should probably be fixed. For now (when #20032 lands) I've made that test ignore command line spans.

I'll work on tracking back this span and trying to fix this.

@Manishearth
Copy link
Member Author

nikomatsakis@9e4e882

@nikomatsakis
Copy link
Contributor

I don't understand. I know the source of that particular error, are you saying that we get another? The source of that error is that we don't pass a span into librustc_trans::common::type_is_sized() and thus have to gin one up.

@Manishearth
Copy link
Member Author

(I'm working on this, got some ideas as to why it's happening)

@kmcallister kmcallister added A-testsuite Area: The testsuite used to check the correctness of rustc A-diagnostics Area: Messages for errors, warnings, and lints labels Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants