Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor librustc_back to support arbitrary linkers #20764

Closed
retep998 opened this issue Jan 8, 2015 · 2 comments
Closed

Refactor librustc_back to support arbitrary linkers #20764

retep998 opened this issue Jan 8, 2015 · 2 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@retep998
Copy link
Member

retep998 commented Jan 8, 2015

Currently librustc_back is hardcoded to use a certain method of linking which makes it extremely inflexible for supporting other linkers such as link.exe. It needs to be refactored somehow such that a flexible target spec can specify what linker implementation to use.
@huonw
Copy link
Member

huonw commented Jan 8, 2015

Flexible target specs are loaded at runtime into the compiler, and don't allow implementing a trait for custom behaviour.

(It seems it may not be better to prescribe an implementation strategy.)

@kmcallister kmcallister added A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 9, 2015
@retep998
Copy link
Member Author

This would be fixed by #25350 which does in fact use a trait for the linker as I originally suggested. ( @huonw 😛 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kmcallister @retep998 @huonw