Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pretty identified should identify view items #20931

Closed
nrc opened this issue Jan 11, 2015 · 4 comments
Closed

pretty identified should identify view items #20931

nrc opened this issue Jan 11, 2015 · 4 comments
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nrc
Copy link
Member

nrc commented Jan 11, 2015

No description provided.

@kmcallister kmcallister added A-pretty Area: Pretty printing (including `-Z unpretty`) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jan 11, 2015
@steveklabnik
Copy link
Member

Can you add some more description here?

@nrc
Copy link
Member Author

nrc commented Jan 21, 2015

pretty identified prints the node ids for nodes in the AST. Currently, it does not print them for view items, it should.

However, note that @eddyb has a PR somewhere for unifying view items with regular items which might fix this.

@goffrie
Copy link
Contributor

goffrie commented Feb 27, 2015

I believe this is fixed now, thanks to the aforementioned PR, #20179.

@nrc
Copy link
Member Author

nrc commented Feb 27, 2015

Fixed!

@nrc nrc closed this as completed Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @kmcallister @nrc @goffrie