Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::f32 impl Float is duplicated #22025

Closed
mdinger opened this issue Feb 6, 2015 · 4 comments
Closed

std::f32 impl Float is duplicated #22025

mdinger opened this issue Feb 6, 2015 · 4 comments
Assignees
@alexcrichton
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Feb 6, 2015

std::f32 doc page has impl Float for f32 at the top and at the bottom.

  • The bottom one seems to have more elements though it's not clear why.
  • Their styling is the same so it's not obvious if they should mean 2 different things.

Something should change so either they don't look like misshapen clones or it's clear what they mean.
@mdinger mdinger mentioned this issue Feb 7, 2015
Merged
@kmcallister kmcallister added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-libs labels Feb 7, 2015
@aturon aturon removed the A-libs label Feb 16, 2015
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 17, 2015
@Manishearth
Rollup merge of rust-lang#22030 - mdinger:f32_examples, r=steveklabnik
0e89228 
 Some examples for `std::num::Float`

~~This is WIP for making examples for `f32`. This probably won't pass `make tidy` and I'm not sure which `f32` needs documentation. rust-lang#22025 shows 2 sets of `f32` which seems split between `core` and `std`. I'm not sure which should be documented but I started doing a couple from `std`. Easy to move if that's where they go...~~

~~Gotta build it eventually to actually see if the docs actually appear where I think they will or if I'm just disillusioned.~~

cc @steveklabnik
@nagisa
Copy link
Member

nagisa commented Mar 1, 2015

Possibly a dupe of #21474

@mdinger
Copy link
Contributor Author

mdinger commented Mar 1, 2015

Perhaps but this doesn't use globs as far as I can tell which is the requirement for that other bug.

@nagisa
Copy link
Member

nagisa commented Mar 1, 2015

Ah right, one is core::num::Float and another is std::num::Float. Two distinct traits.

@mdinger
Copy link
Contributor Author

mdinger commented Mar 1, 2015

I'm not sure what can be done here then. Since core is in general not recommended to be used, maybe external linking (from outside of core) to it should be opt-in, not opt out. Then these links would only appear where an author decides it's useful.

@alexcrichton alexcrichton self-assigned this Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @kmcallister @nagisa @aturon @mdinger