Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rand is gone, fix the book #22518

Closed
steveklabnik opened this issue Feb 19, 2015 · 5 comments
Closed

rand is gone, fix the book #22518

steveklabnik opened this issue Feb 19, 2015 · 5 comments
Assignees
@steveklabnik
Labels
P-medium Medium priority
Milestone
1.0

Comments

@steveklabnik
Copy link
Member

rust-lang/rfcs#722

The Guessing Game won't work now.
@steveklabnik
Copy link
Member Author

nominating for 1.0-beta

This was referenced Feb 21, 2015
Closed
Closed
@vks
Copy link
Contributor

vks commented Feb 23, 2015

I think the easiest fix is hard-coding a number. A proper random number generation can be implemented after cargo has been introduced.

@steveklabnik
Copy link
Member Author

I actually have some bigger plans maybe, so we'll see. Nobody should tackle this ticket in the meantime, I'll be handling it.

@steveklabnik steveklabnik self-assigned this Feb 23, 2015
@pnkfelix
Copy link
Member

1.0 polish, P-high.

@pnkfelix pnkfelix added the P-medium Medium priority label Feb 26, 2015
@pnkfelix pnkfelix added this to the 1.0 milestone Feb 26, 2015
@steveklabnik
Copy link
Member Author

Okay, I cannot rely on rand becoming stable, so I will be re-doing this section.

@steveklabnik steveklabnik mentioned this issue Mar 19, 2015
Merged
bors added a commit that referenced this issue Mar 20, 2015
@bors
Auto merge of #23522 - steveklabnik:gh22518, r=Manishearth
cbc660b 
When investigating #22518, this chapter is really the only part that has `rand`, and the rest still works without it. We should have some examples like this, but for now, it's more important to be right than perfect.
@ches ches mentioned this issue Mar 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steveklabnik steveklabnik

Labels
P-medium Medium priority
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@steveklabnik @vks @pnkfelix