-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider if we want to bundle rustc source code in docs #23061
Comments
It's also useful for plugins like Racer. |
@steveklabnik But only if we have raw source code, right? I don't think Racer can consume HTMLized source code files. |
That's what I thought the title was talking about: ' |
Ugh, I think @kmcallister has misunderstood the issue ;) I meant the source code linked from the |
Yes, that's what I meant as well. Feel free to change the title again if you think it's unclear. |
Traige: I thought @brson had an issue on rustup.rs for this, but could not find it. |
It looks to me like there has been confusion on what this issue is even about. This is quite an old issue, and it originally appears to be discussing whether the compiler sources (not std) are included with the docs, assuming that the compiler API docs are even included with the docs (which they no longer are). I'd suggest that since we don't actually distribute the compiler docs at all, this entire issue is subsumed by #29893 (distribute the compiler docs). Also related to #19535 (package source code). |
Currently generated
doc/src
directory is 26MB without compiler docs and 48MB with them. This becomes the largest directory inside generated docs once #23060 lands (doc/rustc
is over 90MB before that patch, for the reference). It will also interfere with #2206, as we would no longer have source codes to dump.It takes about 5MB in the gzipped tarball, so this is not negligible size. We can instead link to the source code in static.rust-lang.org or, possibly, Github with a permalink.
The text was updated successfully, but these errors were encountered: