-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host compiler documentation #29893
Comments
@Manishearth how are you currently generating the contents of https://github.com/Manishearth/rust-internals-docs ? |
|
This probably belongs on the forge. /cc @nikomatsakis |
cc @mgattozzi, who is working on this. |
oh, they were already cc'd =), sorry |
I mentioned in #42359 what I was doing and the status of things |
The "compiler plugins developers" part of the audience for this is shrinking with procedural macros 1.1 / 2.0, but this can still be useful for people working on the compiler or on custom lint plugins. In my case, I’d use these docs when one of Servo’s lint plugins breaks in a compiler update. So to be useful they need to stay up to date with master or Nightly, and aren’t updated only when someone remembers to do it |
According to #45366, building the compiler docs now require a full-bootstrap compiler, meaning we can only do it on the |
No, you just need a stage2 compiler, no need for full bootstrap. The requirement is that target libraries and sysroot libraries are identical due to how proc macros work today. |
Host compiler documentation Fixes #29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes #29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes #29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes rust-lang#29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes rust-lang#29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes rust-lang#29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Host compiler documentation Fixes rust-lang#29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Re-opening as this still depends on this rust-lang/rust-central-station#40 to land. |
https://doc.rust-lang.org/nightly/nightly-rustc/rustc/ is up. Should it use |
@alexcrichton @SimonSapin I agree that this would be very useful, I've submitted a PR that should handle this: #49654. |
If we are documenting private items, I hope rustdoc can clearly indicate that an item is private (or Also, I hope there's a cc @rust-lang/docs |
I've long wanted --document-private-items to produce a "Private" checkbox that lets you toggle private items as well. Maybe I'll work on that if @QuietMisdreavus thinks its a good idea |
I would appreciate that, since those little yellow boxes take up a lot of space... EDIT: and all of the |
Host compiler documentation: Include private items Fixes rust-lang#29893. Now that compiler documentation is being hosted, including private items seems sensible as these types are going to be being used by contributors working on the compiler. However, including this means that doc comments that contain codeblocks with invalid Rust and can fail the documenting of a given crate (as evidenced by the changes in the second commit included in this PR). We'd need some way of ensuring that this cannot happen so that these failures don't cause documenting to fail. I'm unsure whether this change to documentation steps will cause this to happen already or if something new will be required. r? @alexcrichton
The API documentation for the compiler is useful, and only available online via @Manishearth. It should be hosted by rust-lang.
Need to decide where on the doc server they are hosted - probably separately from the end-user docs; ensure the makefiles can produce them in a separate location from the user docs; add the build rule to the dist builders; make buildbot upload them to the right place.
cc @edunham
UPDATE: Mentoring instructions available here.
The text was updated successfully, but these errors were encountered: